Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <1098434927.1236595130523.JavaMail.jira@brutus>
Date: Mon, 9 Mar 2009 03:38:50 -0700 (PDT)
From: "Michael McCandless (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Resolved: (LUCENE-1552) IndexWriter.addIndexes(IndexReader[]
 readers) doesn't correctly handle exception success flag.
In-Reply-To: <119716383.1236199316129.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/LUCENE-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-1552.
----------------------------------------

    Resolution: Fixed

> IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1552
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1552
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.4
>         Environment: Java
>            Reporter: Scott Garland
>            Assignee: Michael McCandless
>             Fix For: 2.4.1, 2.9
>
>
> After this bit of code in addIndexes(IndexReader[] readers)
>  try {
>         flush(true, false, true);
>         optimize();					  // start with zero or 1 seg
>         success = true;
>       } finally {
>         // Take care to release the write lock if we hit an
>         // exception before starting the transaction
>         if (!success)
>           releaseWrite();
>       }
> The success flag should be reset to "false" because it's used again in another try/catch/finally block.  
> TestIndexWriter.testAddIndexOnDiskFull() sometimes will hit this bug; but it's infrequent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org