[ https://issues.apache.org/jira/browse/LUCENE-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677968#action_12677968 ] 

Mark Harwood commented on LUCENE-1500:
--------------------------------------

Isn't your example predicated on being given an invalid Token with end<start?

What did you think of my suggestion to fix this problem at it's source - i.e. Token should never be in a state with end<start in the first place?

Acheiving this goal is complicated by the fact that offsets are not only set in the constructor - there are independent set methods for start and end offsets which can be called in any order.
One solution would be to deprecate Token.setStartOffset and Token.endOffset and replacing with a Token.setExtent(int startOffset, int endOffset) with the appropriate checks.





> Highlighter throws StringIndexOutOfBoundsException
> --------------------------------------------------
>
>                 Key: LUCENE-1500
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1500
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/highlighter
>    Affects Versions: 2.4
>         Environment: Found this running the example code in Solr (latest version).
>            Reporter: David Bowen
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>         Attachments: Lucene-1500-NewException.patch, LUCENE-1500.patch, patch.txt
>
>
> Using the canonical Solr example (ant run-example) I added this document (using exampledocs/post.sh):
> <add><doc>
>   <field name="id">Test for Highlighting StringIndexOutOfBoundsExcdption</field>
>   <field name="name">Some Name</field>
>   <field name="manu">Acme, Inc.</field>
>   <field name="features">Description of the features, mentioning various things</field>
>   <field name="features">Features also is multivalued</field>
>   <field name="popularity">6</field>
>   <field name="inStock">true</field>
> </doc></add>
> and then the URL http://localhost:8983/solr/select/?q=features&hl=true&hl.fl=features caused the exception.
> I have a patch.  I don't know if it is completely correct, but it avoids this exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org