lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: Make TermScorer non final
Date Fri, 27 Mar 2009 21:03:46 GMT
On Wed, Mar 18, 2009 at 8:59 AM, Simon Willnauer
<simon.willnauer@googlemail.com> wrote:

> One thing I wanna mention aside: As long as TermScorer is final there
> is no problem with the implementation beside some redundant code. The
> TermScorer does not use the float score() method to calculate the
> score in score(HitCollector, int). It rather duplicates the code for
> performance reasons I assume. I have cleaned up this code a little bit
> as I was going to implement payloads using this class. If it is
> desirable to have this code cleaned up I can submit a patch.

Please do submit a patch?  Thanks!

There's no sense in increasing redundant code...

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message