lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Earwin Burrfoot <>
Subject Re: Is TopDocCollector's collect() implementation correct?
Date Thu, 26 Mar 2009 13:45:59 GMT
> BTW, I like the name ResultsCollector, as it's just like HitCollector, but does not commit
too much to "hits" .. i.e., facets aren't hits ... I think?
What this class consumes and what it produces is a totally different
thing. HitCollector always collects 'hits', and then produces whatever
implementor needs.
For example mine collects hits, then collapses 1..N sequential hits
into a 'metahit', calculates facets, sorts, takes top and loads some
fields. And another one simply counts the hits without doing anything
else. But oh, my, I'm not implementing anything like "void
collect(Facet f)" method.

It's common sense to name consumer interfaces after what they consume,
not what their implementations might do.

> Or do you have an alternative?
HitCollector is absolutely cool with me. Okay, maybe DocCollector, or
DocIdCollector. Since that is exactly what 'all' of its
implementations do.

Kirill Zakharenko/Кирилл Захаренко (
Home / Mobile: +7 (495) 683-567-4 / +7 (903) 5-888-423
ICQ: 104465785

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message