lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Otis Gospodnetic <otis_gospodne...@yahoo.com>
Subject Re: Is minor code cleanup desirable?
Date Fri, 13 Mar 2009 17:35:46 GMT

I haven't looked at that code in a while, but I bet it could use some comment/explanation
love.  Consider doing that if you'll be going through that "corner" of the code base.

Otis
--
Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch



----- Original Message ----
> From: Michael McCandless <lucene@mikemccandless.com>
> To: java-dev@lucene.apache.org
> Sent: Friday, March 13, 2009 6:43:36 AM
> Subject: Re: Is minor code cleanup desirable?
> 
> 
> Yes, please!  Bit by bit...
> 
> Start with a small patch so we can iterate / move in the right  
> direction.  Progress not perfection!
> 
> Mike
> 
> Simon Willnauer wrote:
> 
> > Hi,
> > currently I walk through the current trunk code related to scoring and
> > I find some parts in the code where some minor cleanup / optimization
> > can bring a tiny speed improvement. I do have to look at all this code
> > anyway so I wanna ask if it is desirable to add this minor
> > optimizations.
> > I found a couple of "getter" method calls inside loops which could be
> > assigned to final local variables or  local variables which could be
> > final.
> > I know this bring just a very very slight optimization but during the
> > score process every instruction could be useful.
> >
> > If it is desirable I will prepare some diffs where it is appropriate
> > and add them to JIRA.
> >
> > simon
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: java-dev-help@lucene.apache.org
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message