lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Torin Danil (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1551) Add reopen(IndexCommit) methods to IndexReader
Date Thu, 05 Mar 2009 08:15:56 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679115#action_12679115
] 

Torin Danil commented on LUCENE-1551:
-------------------------------------

Since we moved delete to IndexWriter, I strongly feel that IndexReader SHOULD be always read-only,
so your patch makes perfect sense to me.

I know that there are still some operations that IndexWriter can't do, and real-time search
needs them,
so that's why LUCENE-1516 was created, right? But those guys don't need to open previous commit
point,
they need latest & greatest, so the patch should work for them too.

But in the end (lucene4, or maybe sooner?), could it be possible to move all modifying methods
to IndexWriter and let IndexReader to be what it says it is: a READER?

Beside this totally random talk, the patch looks good, I'll try to test it in a day or two
and let you know if there are any problems.




> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
>                 Key: LUCENE-1551
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1551
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.9
>         Environment: Any
>            Reporter: Torin Danil
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1551.patch
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously
saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message