lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Garland (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-1552) IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.
Date Wed, 04 Mar 2009 20:41:56 GMT
IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.
----------------------------------------------------------------------------------------------

                 Key: LUCENE-1552
                 URL: https://issues.apache.org/jira/browse/LUCENE-1552
             Project: Lucene - Java
          Issue Type: Bug
    Affects Versions: 2.4
         Environment: Java
            Reporter: Scott Garland


After this bit of code in addIndexes(IndexReader[] readers)

 try {
        flush(true, false, true);
        optimize();					  // start with zero or 1 seg
        success = true;
      } finally {
        // Take care to release the write lock if we hit an
        // exception before starting the transaction
        if (!success)
          releaseWrite();
      }

The success flag should be reset to "false" because it's used again in another try/catch/finally
block.  

TestIndexWriter.testAddIndexOnDiskFull() sometimes will hit this bug; but it's infrequent.




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message