lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yonik Seeley <yo...@lucidimagination.com>
Subject TrieRange
Date Fri, 06 Feb 2009 22:00:33 GMT
I've taken a quick peek at TrieUtils/TrieRangeQuery - nice work Uwe!

One general comment is that it seems like TrieUtils tries to do a
little too much for users (and in the process covers up some
functionallity).
For example, whether to encode values in two fields and exactly what
those fields are named, seems like it should be under developer
control.  Likewise, developers should be in control of creating and
adding fields to documents and setting other properties like
omitTerms, omitNorms, etc.

Encoding a slice per character makes the code simpler, but increases
the size of the index... but perhaps not enough to worry about in
practice?

What's the synchronization for... a mistaken remnant from a previous draft?

-Yonik

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message