lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: reopen bug cloning norms for all fields
Date Sat, 07 Feb 2009 10:36:18 GMT

Woops, thanks Yonik.  The bug is real and your fix looks right,

Mike

Yonik Seeley wrote:

> It looks like this was introduced just recently in LUCENE-1314.
> I've just committed this fix along with test modifications that fail
> w/o this patch.
>
> -Yonik
>
> On Fri, Feb 6, 2009 at 10:15 PM, Yonik Seeley
> <yonik@lucidimagination.com> wrote:
>> After an NPE and a quick gander at SegmentReader, it looks like it's
>> trying to clone the norms for *all* fields, regardless of if they are
>> indexed.
>> The following is the simplest patch that seems to fix things, but I'm
>> wondering if other changes might be warranted (like where
>> fieldNormsChanged is set... should we only check for indexed fields
>> that have norms enabled?  or if we should have CHANGED/UNCHANGED/NONE
>> rather than true/false)
>>
>> -Yonik
>>
>> Index: src/java/org/apache/lucene/index/SegmentReader.java
>> ===================================================================
>> --- src/java/org/apache/lucene/index/SegmentReader.java (revision  
>> 741813)
>> +++ src/java/org/apache/lucene/index/SegmentReader.java (working  
>> copy)
>> @@ -722,7 +722,8 @@
>>        if (doClone || !fieldNormsChanged[i]) {
>>          final String curField = fieldInfos.fieldInfo(i).name;
>>          Norm norm = (Norm) this.norms.get(curField);
>> -          clone.norms.put(curField, norm.clone());
>> +          if (norm != null)
>> +            clone.norms.put(curField, norm.clone());
>>        }
>>      }
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message