Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 64706 invoked from network); 3 Dec 2008 18:06:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Dec 2008 18:06:21 -0000 Received: (qmail 48172 invoked by uid 500); 3 Dec 2008 18:06:28 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 47654 invoked by uid 500); 3 Dec 2008 18:06:27 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 47638 invoked by uid 99); 3 Dec 2008 18:06:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 10:06:27 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2008 18:04:56 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id CB944234C2A9 for ; Wed, 3 Dec 2008 10:05:44 -0800 (PST) Message-ID: <1004460425.1228327544832.JavaMail.jira@brutus> Date: Wed, 3 Dec 2008 10:05:44 -0800 (PST) From: "Andi Vajda (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-1390) add ISOLatinAccentFilter and deprecate ISOLatin1AccentFilter In-Reply-To: <236365785.1221680384302.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652875#action_12652875 ] Andi Vajda commented on LUCENE-1390: ------------------------------------ Ah, I see now what you're asking for. Sorry about the misunderstanding. I believe I had picked 'e' for schwa because it looks closest to that letter. I have no objections to switching to using 'a' instead if that's more "correct". This Wikipedia seems to agree: http://en.wikipedia.org/wiki/Schwa_(Cyrillic) This other Wikipedia http://en.wikipedia.org/wiki/Schwa is less clear about this, but it seems that using 'a' instead of 'e' doesn't contradict it. Steven, I can amend the patch but you said you had more changes coming. If that's the case, could you please add this change as well. If that's not the case, is it ok for me to add this change and call for this bug to be committed to trunk and closed ? > add ISOLatinAccentFilter and deprecate ISOLatin1AccentFilter > ------------------------------------------------------------ > > Key: LUCENE-1390 > URL: https://issues.apache.org/jira/browse/LUCENE-1390 > Project: Lucene - Java > Issue Type: Improvement > Components: Analysis > Environment: any > Reporter: Andi Vajda > Priority: Minor > Fix For: 2.9 > > Attachments: ASCIIFoldingFilter.patch, ASCIIFoldingFilter.patch, ISOLatinAccentFilter.java > > > The ISOLatin1AccentFilter is removing accents from accented characters in the ISO Latin 1 character set. > It does what it does and there is no bug with it. > It would be nicer, though, if there was a more comprehensive version of this code that included not just ISO-Latin-1 (ISO-8859-1) but the entire Latin 1 and Latin Extended A unicode blocks. > See: http://en.wikipedia.org/wiki/Latin-1_Supplement_unicode_block > See: http://en.wikipedia.org/wiki/Latin_Extended-A_unicode_block > That way, all languages using roman characters are covered. > A new class, ISOLatinAccentFilter is attached. It is intended to supercede ISOLatin1AccentFilter which should get deprecated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org