Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 19637 invoked from network); 22 Dec 2008 11:38:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Dec 2008 11:38:19 -0000 Received: (qmail 76585 invoked by uid 500); 22 Dec 2008 11:38:13 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 76501 invoked by uid 500); 22 Dec 2008 11:38:13 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 76492 invoked by uid 99); 22 Dec 2008 11:38:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Dec 2008 03:38:13 -0800 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [74.125.92.27] (HELO qw-out-2122.google.com) (74.125.92.27) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Dec 2008 11:38:05 +0000 Received: by qw-out-2122.google.com with SMTP id 5so804358qwi.53 for ; Mon, 22 Dec 2008 03:37:41 -0800 (PST) Received: by 10.214.79.10 with SMTP id c10mr5831445qab.73.1229945861611; Mon, 22 Dec 2008 03:37:41 -0800 (PST) Received: from ?10.17.4.4? (pool-173-48-164-75.bstnma.fios.verizon.net [173.48.164.75]) by mx.google.com with ESMTPS id 7sm13363612ywo.37.2008.12.22.03.37.40 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 22 Dec 2008 03:37:40 -0800 (PST) Message-Id: <023352A2-B66E-4ECD-ACF8-D71024397A65@mikemccandless.com> From: Michael McCandless To: java-dev@lucene.apache.org In-Reply-To: <786fde50812212246i3909d591td660c7d7689cf929@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Subject: Re: IndexFileNameFilter Date: Mon, 22 Dec 2008 06:37:38 -0500 References: <786fde50812212246i3909d591td660c7d7689cf929@mail.gmail.com> X-Mailer: Apple Mail (2.929.2) X-Virus-Checked: Checked by ClamAV on apache.org I think this makes sense. Can you submit patch? Thanks Shai. Mike Shai Erera wrote: > Hi > > Is IndexFileNameFilter supposed to be a singleton (looks like it)? > If so, shouldn't its constructor be private? > Also, since it has a static getFilter() method, its singleton should > also be private. > I checked and there are no references to either the singleton or the > constructor outside this class, so the change should not cause any > issues. > > Shai --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org