lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: To clone or have a pluggable docidbitset for IndexReader
Date Tue, 16 Dec 2008 22:33:30 GMT

Jason Rutherglen wrote:

> > ie "snapshot" the previous reader without going through disk as  
> intermediary, right?
>
> Yes.
>
> >  refuses any further changes to itself (freezes itself)
>
> Should I create a new variable for "refuse updates/freeze" or use  
> readonly?  If the variable is true then inside of doClose throw an  
> exception?  If someone tries to clone a cloned reader that has no  
> lock then the resulting reader is frozen as well.  Let define more  
> about how frozen behaves and the exceptions thrown and from where  
> for a frozen reader.

Setting readOnly seems reasonable, on quick thought.  You should add a  
testcase that asserts an exception is hit on trying to make changes to  
a cloned reader.

> Copy on write for norms and deletedocs is implemented, now that  
> we've more or less agreed on the rules, I can make sure the unit  
> tests reflect testing the rules.
>
> > If this makes sense, can you update the patch on LUCENE-1314 to  
> enforce these semantics?
>
> Yes.
>
> > I think we should get this in for 2.9?
>
> Should be doable!

OK thanks!

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message