lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
Date Wed, 17 Dec 2008 18:55:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657481#action_12657481
] 

Michael McCandless commented on LUCENE-1483:
--------------------------------------------

{quote}
> Would we have a subclass that overrides this that's used as a base class for optimized
implementations?
{quote}

If we do this, I don't think we need a new base class for "expert" collectors; they can simply
subclass HitCollector & override the setNextReader method?

Though one downside of this approach is the "simple" HitCollector API is polluted with this
advanced method, and HitCollector's collect method gets different args depending on what that
method returns.  It's a somewhat confusing API.

I guess Id' actually prefer subclassing HitCollector (SequentialHitCollector?  AdvancedHitCollector?
 SegmentedHitCollector?), adding setNextReader only to that subclass, and using instanceof
to wrap HitCollector subclasses.

> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-1483
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1483
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 2.9
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing for individual
segment reloading on reopen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message