lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1473) Implement Externalizable in main top level searcher classes
Date Tue, 02 Dec 2008 23:28:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652591#action_12652591
] 

Doug Cutting commented on LUCENE-1473:
--------------------------------------

The attached patch optimizes java serialization.  Also, if we want java serialization to work
cross-version, it gives us a leg to stand on.  It doesn't change anything for most Lucene
users, since Lucene doesn't use java serialization except for RMI.  So, today, if you're using
RemoteSearcher, and the local and remote versions have different versions of Term.java, things
will probably fail, since, by default, the serialVersionUID is a hash of the method signatures
and fields.  If we want RemoteSearcher to work cross-version, then we need to explicitly manage
the serialVersionUID and readExternal/writeExternal implementations.  But is that really a
priority?

As with all optimizations, the performance improvement should be measured and demonstrated
to be significant.  Also, an invasive change like this is hard to justify when so little of
Lucene depends on java serialization.



> Implement Externalizable in main top level searcher classes
> -----------------------------------------------------------
>
>                 Key: LUCENE-1473
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1473
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.4
>            Reporter: Jason Rutherglen
>            Priority: Minor
>         Attachments: LUCENE-1473.patch
>
>
> To maintain serialization compatibility between Lucene versions, major classes can implement
Externalizable.  This will make Serialization faster due to no reflection required and maintain
backwards compatibility.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message