lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1483) Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
Date Wed, 17 Dec 2008 18:41:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657476#action_12657476
] 

Doug Cutting commented on LUCENE-1483:
--------------------------------------

> Woah! Don't make me switch all that again!

Sorry, I'm just tossing out ideas.  Don't take me too seriously...

> The reason I lost the instanceof is that we would have to deprecate the HitCollector
implementations because they need to extend HitCollector.

Would we?  I was suggesting that, if we're going to have two APIs, one expert and one non-expert,
then we could make the expert API a subclass and not deprecate or otherwise alter HitCollector.
 I do not like using exceptions for normal control flow.  Instanceof is better, but not ideal.
 A default implementation of an expert method that returns 'false', as Mike suggested, isn't
bad and might be best.  It requires neither deprecation, exceptions nor instanceof.  Would
we have a subclass that overrides this that's used as a base class for optimized implementations?


> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-1483
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1483
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 2.9
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing for individual
segment reloading on reopen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message