lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <>
Subject [jira] Commented: (LUCENE-1451) Can't create NIOFSDirectory w/o setting a system property
Date Wed, 12 Nov 2008 23:23:44 GMT


Yonik Seeley commented on LUCENE-1451:

bq.  if i'm reading it right, this patch won't work if two different callers ask for Directories
backed by the same File using different directoryImpl instances ... the first one will go
into the DIRECTORIES cache and "win" for all future calls.

Right... the tests in the patch test for this too.  If an instance already exists, then it's
returned.  If all the instances are closed, the desired implementation can be returned.  
So it won't be for all future calls, but it would be difficult to ensure you got the implementation
you wanted.

bq. Hmm good point. Actually why do we do this 'single instance of FSDir per File' again?
Is it really needed?

I had assumed it was locking.... but it goes outside of the FSDirectory and operates directly
on File.  So, I'm not sure.

> Can't create NIOFSDirectory w/o setting a system property
> ---------------------------------------------------------
>                 Key: LUCENE-1451
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>            Priority: Minor
>         Attachments: LUCENE-1451.patch, LUCENE-1451.patch
> NIOFSDirectory.getDirectory() returns a FSDirectory object

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message