lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1424) Change all mutli term querys so that they extend MultiTermQuery and allow for a constant score mode
Date Tue, 04 Nov 2008 17:10:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645006#action_12645006
] 

Michael McCandless commented on LUCENE-1424:
--------------------------------------------

Looks good!  I think we're almost done here...

Shouldn't we deprecate ConstantScoreRangeQuery, and maybe change it to
simply subclass RangeQuery and set useConstantScoreRewrite to true?

Should we match the ctor of ConstantScoreRangeQuery (field, lower, upper,
inclLower, inclUpper) with RangeQuery?  Right now you have Term for
lower & upper, not String.

Can we rename MultiTermQuery.isUseConstantScoreRewrite() to
getUseConstantScoreRewrite()?  Or maybe set/getConstantScoreRewrite()?

There seems to be a leftover "abstract class TermGenerator implements
IdGenerator" at the bottom of Prefixquery.java.

Small whitespace issue: you need to insert a space in "if(..." in a
few places.


> Change all mutli term querys so that they extend MultiTermQuery and allow for a constant
score mode
> ---------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1424
>             Project: Lucene - Java
>          Issue Type: New Feature
>            Reporter: Mark Miller
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch,
LUCENE-1424.patch
>
>
> Cleans up a bunch of code duplication, closer to how things should be - design wise,
gives us constant score for all the multi term queries, and allows us at least the option
of highlighting the constant score queries without much further work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message