lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adriano Crestani" <adrianocrest...@apache.org>
Subject Re: Bug in FieldInfo (omitTF)?
Date Tue, 18 Nov 2008 09:27:02 GMT
I'm almost sure this was not the expected logic.

Otherwise the "this.omitTf = true" statement will never be executed.

Based on code logic, it should probably be what you are saying: "this.omitTf
!= other.omitTf" instead of "this.omitTf omitTf" : )

Regards,
Adriano Crestani Campos

On Tue, Nov 18, 2008 at 1:09 AM, Shai Erera <serera@gmail.com> wrote:

> Hi
>
> I looked at FieldInfo and found this line (95):
>
>     if (this.omitTf != omitTf) {
>       this.omitTf = true;                // if one require omitTf at least
> once, it remains off for life
>     }
>
> Shouldn't it be:
>     if (this.omitTf != other.omitTf) {
>       this.omitTf = true;                // if one require omitTf at least
> once, it remains off for life
>     }
>
> The first version compares the field to itself ...
>
> Shai
>

Mime
View raw message