lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1424) Change all mutli term querys so that they extend MultiTermQuery and allow for a constant score mode
Date Sun, 09 Nov 2008 12:28:46 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated LUCENE-1424:
---------------------------------------

    Attachment: LUCENE-1424.patch


OK I made some changes to the patch -- I think we are real close now:

  * Overrode WildcardQuery.rewrite to return TermQuery if the pattern has
    no wildcards (your suggestion above).

  * Simplified MultiTermFilter: made it a static inner class, moved
    TermGenerator inside it (absorbed IdGenerator interface into it),
    move bits() and getDocIdSet() out of the anonymous class,
    simplified the equals method.

  * Removed extra TermGenerator class from PrefixQuery.

  * Fixed but RangeFilter's ctor -- I think you could have gotten null
    rangeQuery if you pass in null collator.

  * Various small javadoc fixes, renaming, refactoring.

  * Deprecated ConstantScoreRangeQuery in favor of RangeQuery.

  * Overrode FuzzyQuery.setConstantScoreRewrite to throw
    UnsupportedOperationException, because it overrides rewrite.

  * Added set/getConstantScoreRewrite to QueryParser (defaults to
    true) and deprecated set/getUseOldRangeQuery.

  * Deprecated the ctor's of RangeQuery that take Term (in favor of
    String versions); removed new ctors in RangeQuery that take Term
    for upper/lower val.

Mark can you look this over and see if the changes are OK?  Thanks.

> Change all mutli term querys so that they extend MultiTermQuery and allow for a constant
score mode
> ---------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1424
>             Project: Lucene - Java
>          Issue Type: New Feature
>            Reporter: Mark Miller
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch,
LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch,
LUCENE-1424.patch
>
>
> Cleans up a bunch of code duplication, closer to how things should be - design wise,
gives us constant score for all the multi term queries, and allows us at least the option
of highlighting the constant score queries without much further work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message