lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1410) PFOR implementation
Date Mon, 06 Oct 2008 17:57:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637154#action_12637154
] 

Michael McCandless commented on LUCENE-1410:
--------------------------------------------

bq. One detail on the generated code: the final mask can be omitted, for example the last
bit extraction for the 5 bit case:

Ahh good catch.  I'll fix in my autogen.

bq. Meanwhile I also have a java program generator for decompression, and I got very similar
results.

Excellent!  Did you also switch to relative getInts?  This way, I could change my TestPFor2
to rely on self-punctuation when reading.  And, I can pass down a ByteBuffer derived directly
from the file, instead of copying bytes into byte[] first.  This would make the test more
fair to pfor.

bq. I found a bug for the 17 bits case in decodeAnyFrame(), this might explain the sum test
failure that you saw.

OK I can re-test when you post this, to see if the checksums match.

> PFOR implementation
> -------------------
>
>                 Key: LUCENE-1410
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1410
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Other
>            Reporter: Paul Elschot
>            Priority: Minor
>         Attachments: autogen.tgz, LUCENE-1410b.patch, TestPFor2.java, TestPFor2.java,
TestPFor2.java
>
>   Original Estimate: 21840h
>  Remaining Estimate: 21840h
>
> Implementation of Patched Frame of Reference.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message