Return-Path: 
 <java-dev-return-27121-apmail-lucene-java-dev-archive=lucene.apache.org@lucene.apache.org>
Delivered-To: apmail-lucene-java-dev-archive@www.apache.org
Received: (qmail 21430 invoked from network); 3 Sep 2008 17:08:16 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 3 Sep 2008 17:08:16 -0000
Received: (qmail 91034 invoked by uid 500); 3 Sep 2008 17:08:13 -0000
Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org
Received: (qmail 90497 invoked by uid 500); 3 Sep 2008 17:08:12 -0000
Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:java-dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:java-dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:java-dev@lucene.apache.org>
List-Id: <java-dev.lucene.apache.org>
Reply-To: java-dev@lucene.apache.org
Delivered-To: mailing list java-dev@lucene.apache.org
Received: (qmail 90488 invoked by uid 99); 3 Sep 2008 17:08:12 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2008 10:08:12 -0700
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2008 17:07:13 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 8E66F234C1CA
	for <java-dev@lucene.apache.org>; Wed,  3 Sep 2008 10:07:44 -0700 (PDT)
Message-ID: <1976199623.1220461664582.JavaMail.jira@brutus>
Date: Wed, 3 Sep 2008 10:07:44 -0700 (PDT)
From: "Chris Harris (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Issue Comment Edited: (LUCENE-1374) Merging of compressed
 string Fields may hit NPE
In-Reply-To: <910897042.1220436944276.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/LUCENE-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628055#action_12628055 ] 

ryguasu edited comment on LUCENE-1374 at 9/3/08 10:07 AM:
---------------------------------------------------------------

"ant test" on 691617 for me fails on the following test:

  <testcase classname="org.apache.lucene.index.TestIndexWriter" name="testMergeCompressedFields" time="0.36">
    <error message="could not delete C:\lucene\691647\build\test\mergecompressedfields\_5.cfs" type="java.io.IOException">java.io.IOException: could not delete C:\lucene\691647\build\test\mergecompressedfields\_5.cfs
	at org.apache.lucene.util._TestUtil.rmDir(_TestUtil.java:37)
	at org.apache.lucene.index.TestIndexWriter.testMergeCompressedFields(TestIndexWriter.java:4111)
</error>
  </testcase>

It might be one of those things that shows up only on Windows. In any case, adding a call to IndexReader.close() in testMergeCompressedFields() seems to fix things up:

{code}
      IndexReader r = IndexReader.open(dir);
      for(int i=0;i<5;i++) {
        Document doc = r.document(i);
        assertEquals("this is some data that will be compressed this this this", doc.getField("test1").stringValue());
        byte[] b = doc.getField("test2").binaryValue();
        assertTrue(Arrays.equals(b, cmp));
      }
      r.close();  // <------------------------------- New line
    } finally {
      dir.close();
      _TestUtil.rmDir(indexDir);
    }
{code}

I guess technically the r.close() probably belongs in a finally block as well.

      was (Author: ryguasu):
    "ant test" on 691617 for me fails on the following test:

  <testcase classname="org.apache.lucene.index.TestIndexWriter" name="testMergeCompressedFields" time="0.36">
    <error message="could not delete C:\lucene\691647\build\test\mergecompressedfields\_5.cfs" type="java.io.IOException">java.io.IOException: could not delete C:\lucene\691647\build\test\mergecompressedfields\_5.cfs
	at org.apache.lucene.util._TestUtil.rmDir(_TestUtil.java:37)
	at org.apache.lucene.index.TestIndexWriter.testMergeCompressedFields(TestIndexWriter.java:4111)
</error>
  </testcase>

It might be one of those things that shows up only on Windows. In any case, adding a call to IndexReader.close() in testMergeCompressedFields() seems to fix things up:

      IndexReader r = IndexReader.open(dir);
      for(int i=0;i<5;i++) {
        Document doc = r.document(i);
        assertEquals("this is some data that will be compressed this this this", doc.getField("test1").stringValue());
        byte[] b = doc.getField("test2").binaryValue();
        assertTrue(Arrays.equals(b, cmp));
      }
      r.close();  // <------------------------------- New line
    } finally {
      dir.close();
      _TestUtil.rmDir(indexDir);
    }

I guess technically the r.close() probably belongs in a finally block as well.
  
> Merging of compressed string Fields may hit NPE
> -----------------------------------------------
>
>                 Key: LUCENE-1374
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1374
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 2.4
>
>         Attachments: LUCENE-1374.patch
>
>
> This bug was introduced with LUCENE-1219 (only present on 2.4).
> The bug happens when merging compressed string fields, but only if bulk-merging code does not apply because the FieldInfos for the segment being merged are not congruent.  This test shows the bug:
> {code}
>   public void testMergeCompressedFields() throws IOException {
>     File indexDir = new File(System.getProperty("tempDir"), "mergecompressedfields");
>     Directory dir = FSDirectory.getDirectory(indexDir);
>     try {
>       for(int i=0;i<5;i++) {
>         // Must make a new writer & doc each time, w/
>         // different fields, so bulk merge of stored fields
>         // cannot run:
>         IndexWriter w = new IndexWriter(dir, new WhitespaceAnalyzer(), i==0, IndexWriter.MaxFieldLength.UNLIMITED);
>         w.setMergeFactor(5);
>         w.setMergeScheduler(new SerialMergeScheduler());
>         Document doc = new Document();
>         doc.add(new Field("test1", "this is some data that will be compressed this this this", Field.Store.COMPRESS, Field.Index.NO));
>         doc.add(new Field("test2", new byte[20], Field.Store.COMPRESS));
>         doc.add(new Field("field" + i, "random field", Field.Store.NO, Field.Index.TOKENIZED));
>         w.addDocument(doc);
>         w.close();
>       }
>       byte[] cmp = new byte[20];
>       IndexReader r = IndexReader.open(dir);
>       for(int i=0;i<5;i++) {
>         Document doc = r.document(i);
>         assertEquals("this is some data that will be compressed this this this", doc.getField("test1").stringValue());
>         byte[] b = doc.getField("test2").binaryValue();
>         assertTrue(Arrays.equals(b, cmp));
>       }
>     } finally {
>       dir.close();
>       _TestUtil.rmDir(indexDir);
>     }
>   }
> {code}
> It's because in FieldsReader, when we load a field "for merge" we create a FieldForMerge instance which subsequently does not return the right values for getBinary{Value,Length,Offset}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org