lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1402) CheckIndex API changed without backwards compaitibility
Date Wed, 24 Sep 2008 08:51:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634064#action_12634064
] 

Michael McCandless commented on LUCENE-1402:
--------------------------------------------

bq. In my opinion, for consistency, the fix() method should spell fixIndex() like checkIndex().

OK I'll do this.

bq. Maybe the CheckIndexStatus class could be an inner class like the others. 

And this too.

Thanks!

> CheckIndex API changed without backwards compaitibility
> -------------------------------------------------------
>
>                 Key: LUCENE-1402
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1402
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Uwe Schindler
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-1402-uwe.patch, LUCENE-1402.patch, LUCENE-1402.patch
>
>
> The API of CheckIndex changed. The Check function returns a CheckIndexStatus and not
boolean. And JavaDocs notes the boolean return value.
> I am not sure if it works, but it would be good to have the check method that returns
boolean available @Deprecated, i.e.
> @Deprecated public static CheckIndexStatus check(Directory dir, boolean doFix) throws
IOException {
>  final CheckIndexStatus stat=this.check(dir,doFix);
>  return stat.clean;
> }
> I am not sure, if it can be done with the same method name, but it prevents drop-in-replacements
of Lucene to work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message