lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1131) Add numDeletedDocs to IndexReader
Date Sun, 07 Sep 2008 18:58:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628991#action_12628991
] 

Michael McCandless commented on LUCENE-1131:
--------------------------------------------

bq. What if we implement numDeletedDocs() in IndexReader, instead of defining it abstract?

Right, that's exactly what I'm thinking, with this body:

{code}
public int numDeletedDocs() {
  return maxDoc() - numDocs();
}
{code}

Then I think no classes need to override it (perf cost of calling 2 methods is tiny)?

> Add numDeletedDocs to IndexReader
> ---------------------------------
>
>                 Key: LUCENE-1131
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1131
>             Project: Lucene - Java
>          Issue Type: New Feature
>            Reporter: Shai Erera
>            Assignee: Otis Gospodnetic
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: LUCENE-1131.patch
>
>
> Add numDeletedDocs to IndexReader. Basically, the implementation is as simple as doing:
> public int numDeletedDocs() {
>   return deletedDocs == null ? 0 : deletedDocs.count();
> }
> in SegmentReader.
> Patch to follow to include in all IndexReader extensions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message