lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1131) Add numDeletedDocs to IndexReader
Date Mon, 08 Sep 2008 10:56:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629125#action_12629125
] 

Shai Erera commented on LUCENE-1131:
------------------------------------

I agree with the body, that's what I had in mind.

As for extending classes, I agree that calling two methods has little performance overhead,
but it just looks cleaner (for SegmentReader for example). Anyway, I don't have a strong opinion
on whether we should override or not. I'll be fine with either.

> Add numDeletedDocs to IndexReader
> ---------------------------------
>
>                 Key: LUCENE-1131
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1131
>             Project: Lucene - Java
>          Issue Type: New Feature
>            Reporter: Shai Erera
>            Assignee: Otis Gospodnetic
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: LUCENE-1131.patch
>
>
> Add numDeletedDocs to IndexReader. Basically, the implementation is as simple as doing:
> public int numDeletedDocs() {
>   return deletedDocs == null ? 0 : deletedDocs.count();
> }
> in SegmentReader.
> Patch to follow to include in all IndexReader extensions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message