lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Updated: (LUCENE-1402) CheckIndex API changed without backwards compaitibility
Date Tue, 23 Sep 2008 22:15:44 GMT


Michael McCandless updated LUCENE-1402:

    Attachment: LUCENE-1402.patch

OK I merged the two patches.

Uwe, I prefer to keep CheckIndexStatus as a separate class: I don't like that after you create
a new CheckIndex and before you call checkIndex, all of these members are undefined.  I'd
like to keep CheckIndex itself stateless (except for its infoStream).

Otherwise I think everything is merged!

> CheckIndex API changed without backwards compaitibility
> -------------------------------------------------------
>                 Key: LUCENE-1402
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.4
>            Reporter: Uwe Schindler
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-1402-uwe.patch, LUCENE-1402.patch, LUCENE-1402.patch
> The API of CheckIndex changed. The Check function returns a CheckIndexStatus and not
boolean. And JavaDocs notes the boolean return value.
> I am not sure if it works, but it would be good to have the check method that returns
boolean available @Deprecated, i.e.
> @Deprecated public static CheckIndexStatus check(Directory dir, boolean doFix) throws
IOException {
>  final CheckIndexStatus stat=this.check(dir,doFix);
>  return stat.clean;
> }
> I am not sure, if it can be done with the same method name, but it prevents drop-in-replacements
of Lucene to work.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message