Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-Id: <83B86D4F-925B-4346-B470-99BA739B3DA6@mikemccandless.com>
From: Michael McCandless <lucene@mikemccandless.com>
To: java-dev@lucene.apache.org
In-Reply-To: <0DE83926-039E-46FB-ABC2-4667EFC8B07F@apache.org>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v926)
Subject: Re: CheckIndex tool
Date: Mon, 4 Aug 2008 17:01:48 -0400
References: <0DE83926-039E-46FB-ABC2-4667EFC8B07F@apache.org>


This sounds good!  I like the idea of checking the index when Solr has  
to force release the write.lock.

The one caveat is, when checking a large index (which can take quite  
some time), it'd be nice to have the equivalent of the inline'd  
out.print/ln calls happen in realtime so that you can see (on the  
command line output) that progress is being made, which segment is  
being checked, etc.?

Maybe change it to an optional "infoStream" (like IndexWriter), and  
then the current inlined prints become calls to message() which checks  
if infoStream is non-null?

Mike

Grant Ingersoll wrote:

> Hey Mike,
>
> I'm thinking about https://issues.apache.org/jira/browse/SOLR-566  
> and was thinking about adding some more programmatic access to the  
> CheckIndex tool and wanted to see if you had any thoughts.   
> Basically, I am going to to capture info into a simple data  
> structure that can then be introspected and serialized into a  
> RequestHandler, but also something that might be more generally  
> useful in certain cases where things go bad.  I was debating keeping  
> the inline out.printlns, but not sure if they shouldn't just be  
> moved to the main such that the cmd line stuff still works as is,  
> but it doesn't clog the logs for those that want programmatic access.
>
> I'll post a patch soon, but wanted to see if you had any preliminary  
> insight.
>
> -Grant
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org