lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marvin Humphrey (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1061) Adding a factory to QueryParser to instantiate query instances
Date Wed, 27 Aug 2008 11:45:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626083#action_12626083
] 

Marvin Humphrey commented on LUCENE-1061:
-----------------------------------------

> What's wrong with just subclassing QueryParser and overriding the desired methods?

For what it's worth, I find the idea of a separate class appealing from an API documentation
design standpoint.  This usage of QueryParser is relatively arcane. Hiding all these methods
away in a separate class means less clutter and less effort for most people scanning through
the API docs of an important, commonly used class.

> Adding a factory to QueryParser to instantiate query instances
> --------------------------------------------------------------
>
>                 Key: LUCENE-1061
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1061
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: QueryParser
>    Affects Versions: 2.3
>            Reporter: John Wang
>             Fix For: 2.4
>
>         Attachments: lucene_patch.txt
>
>
> With the new efforts with Payload and scoring functions, it would be nice to plugin custom
query implementations while using the same QueryParser.
> Included is a patch with some refactoring the QueryParser to take a factory that produces
query instances.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message