lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (LUCENE-1293) Tweaks to PhraseQuery.explain()
Date Wed, 27 Aug 2008 10:27:44 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless resolved LUCENE-1293.
----------------------------------------

       Resolution: Incomplete
    Fix Version/s:     (was: 2.4)

I think the explain method is primarily used for debugging, and so performance is not really
important.  It's also complex enough as is, and probably not well covered by unit tests, that
I'm nervous about just tweaking it.  I'm resolving this as INCOMPLETE.  Itamar, if you want
to see this resolved, can you post a full patch and we can reconsider it?  Thanks.

> Tweaks to PhraseQuery.explain()
> -------------------------------
>
>                 Key: LUCENE-1293
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1293
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4
>            Reporter: Itamar Syn-Hershko
>            Priority: Minor
>
> The explain() function in PhraseQuery.java is very clumzy and could use many optimizations.
Perhaps it is only because it is intended to use while debugging?
> Here's an example:
> {noformat}
>       result.addDetail(fieldExpl);
>       // combine them
>       result.setValue(queryExpl.getValue() * fieldExpl.getValue());
>       if (queryExpl.getValue() == 1.0f)
>         return fieldExpl;
>       return result;
>    }
> {noformat}
> Can easily be tweaked and become:
> {noformat}
>       if (queryExpl.getValue() == 1.0f) {
>         return fieldExpl;
>       }
>       result.addDetail(fieldExpl);
>       // combine them
>       result.setValue(queryExpl.getValue() * fieldExpl.getValue());
>       return result;
>   }
> {noformat}
> And thats really just for a start...
> Itamar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message