lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher (JIRA)" <>
Subject [jira] Commented: (LUCENE-1061) Adding a factory to QueryParser to instantiate query instances
Date Thu, 28 Aug 2008 09:23:44 GMT


Erik Hatcher commented on LUCENE-1061:

Michael - you are a machine!

+1 to the subclassing approach and your general patch.

What might be even more interesting is to make the newXXX methods return Query instead of
a specific type.  I'm not sure if that would work in all cases (surely not for BooleanQuery),
but might for most of 'em.

For example, what if newTermQuery(Term term) returned a Query instead of a TermQuery?   That'd
add a fair bit more flexibility, as long as none of the calling code needed a specific type
of Query.

The hoops we jump through because we're in Java.... sheesh.  :)

> Adding a factory to QueryParser to instantiate query instances
> --------------------------------------------------------------
>                 Key: LUCENE-1061
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: QueryParser
>    Affects Versions: 2.3
>            Reporter: John Wang
>            Assignee: Michael McCandless
>             Fix For: 2.4
>         Attachments: LUCENE-1061.patch, lucene_patch.txt
> With the new efforts with Payload and scoring functions, it would be nice to plugin custom
query implementations while using the same QueryParser.
> Included is a patch with some refactoring the QueryParser to take a factory that produces
query instances.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message