Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of ning.li.li@gmail.com
 designates 74.125.44.30 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=C2qvlqs4vlVxNzdaqH/Afsk/jUiRmCIkCJEYPF2eBmEKXQZ0hvTVZEG3nlYsp76ih3
         I7Uo+cujk4loDGAfb+E9MPWGGidWBNy+7qgulGkU57/MbQcIwhkrEdPzu49fUC0R5MAC
         StCeS1mjF8D3ZjcNlY7waWDlT8tExSgGVZnAA=
Message-ID: <c7b302c50807111227w1e2192t5ddc1c38e54df851@mail.gmail.com>
Date: Fri, 11 Jul 2008 15:27:51 -0400
From: "Ning Li" <ning.li.li@gmail.com>
To: java-dev@lucene.apache.org
Subject: Re: Commit while addIndexes is in progress
In-Reply-To: <486A779F-E8B2-4EF7-B853-9DB81855F06A@mikemccandless.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <c7b302c50807111018j58b6d08djd56b5889f6b3780d@mail.gmail.com>
	 <486A779F-E8B2-4EF7-B853-9DB81855F06A@mikemccandless.com>

> What should it "mean" when you call commit(), while another thread is in the
> middle of addIndexes?
>
> We could 1) disallow it (throw an exception if you try), 2) allow it but
> block until addIndexes is done, 3) allow it but commit all changes up until
> when addIndexes was first called ... anything else?

I don't have a strong preference. One reasoning is that commit itself
calls flush
and waits for flush to finish. So is 2) more consistent that commit waits for
addIndexes to finish?

We should also disallow concurrent addIndexes, right?


> I think there're similar problems with calling optimize() while addIndexes
> is in progress... I think we should disallow that?

Optimize waits for addIndexes to finish? I think it's useful to allow addIndexes
during maybeMerge and optimize, no?

Cheers,
Ning Li

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org