lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eks Dev (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1345) Allow Filter as clause to BooleanQuery
Date Tue, 29 Jul 2008 16:20:32 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617836#action_12617836
] 

Eks Dev commented on LUCENE-1345:
---------------------------------

bq. comparison with -1 is being optimized away entirely 

I do not think so, how compiler could "optimize away" the only condition that stops the loop?
The loop would never finish, or am I misreading something here? 

Anyhow, the test is so simple that compiler can take completely other direction from the real
case. I guess much better test (without too much effort!) would be to take something like
OpenBitSetIterator and make one Iterator implementation with sentinel approach and then compare...
this test is really just a dumb loop, but on the other side isolates the difference between
two approaches...



> Allow Filter as clause to BooleanQuery
> --------------------------------------
>
>                 Key: LUCENE-1345
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1345
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Paul Elschot
>            Priority: Minor
>         Attachments: DisjunctionDISI.patch, DisjunctionDISI.patch, LUCENE-1345.patch,
LUCENE-1345.patch, TestIteratorPerf.java
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message