lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Rutherglen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1322) Remove synchronization in CompoundFileReader
Date Fri, 11 Jul 2008 16:02:31 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612911#action_12612911
] 

Jason Rutherglen commented on LUCENE-1322:
------------------------------------------

Seeing a possible bug in this patch:

{noformat}
1) testSystem(org.apache.lucene.ocean.TestSystem)java.io.IOException: Negative seek offset
at java.io.RandomAccessFile.seek(Native Method)
at org.apache.lucene.store.FSDirectory$FSIndexInput.readInternal(FSDirectory.java:578)
at org.apache.lucene.store.BufferedIndexInput.readBytes(BufferedIndexInput.java:131)
at org.apache.lucene.index.CompoundFileReader$CSIndexInput.readInternal(CompoundFileReader.java:247)
at org.apache.lucene.store.BufferedIndexInput.refill(BufferedIndexInput.java:152)
at org.apache.lucene.store.BufferedIndexInput.readByte(BufferedIndexInput.java:38)
at org.apache.lucene.store.IndexInput.readInt(IndexInput.java:68)
at org.apache.lucene.store.IndexInput.readLong(IndexInput.java:91)
at org.apache.lucene.index.FieldsReader.doc(FieldsReader.java:212)
at org.apache.lucene.index.SegmentReader.document(SegmentReader.java:760)
at org.apache.lucene.index.IndexReader.document(IndexReader.java:572)
at org.apache.lucene.search.IndexSearcher.doc(IndexSearcher.java:92)
{noformat}

> Remove synchronization in CompoundFileReader
> --------------------------------------------
>
>                 Key: LUCENE-1322
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1322
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.3.1
>            Reporter: Jason Rutherglen
>            Assignee: Michael McCandless
>            Priority: Trivial
>             Fix For: 2.4
>
>         Attachments: lucene-1322.patch
>
>
> Currently there is what seems to be unnecessary synchronization in CompoundFileReader.
 This is solved by cloning the base IndexInput.  Synchronization in low level IO classes creates
lock contention on highly multi threaded Lucene installations, so much so that in many cases
the CPU utilization never reaches the maximum without using something like ParallelMultiSearcher.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message