lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mindaugas Žakšauskas (JIRA) <j...@apache.org>
Subject [jira] Commented: (LUCENE-1203) [PATCH] Allow setting IndexReader to IndexSearcher
Date Mon, 14 Jul 2008 14:26:31 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613329#action_12613329
] 

Mindaugas Žakšauskas commented on LUCENE-1203:
----------------------------------------------

I know I'm posting this after rather insane amount of time, but just wanted to get an opinion
about another approach.

After what has been done for LUCENE-743, would it not make sense to add refresh() method to
the searcher which would reopen() the reader?
My understanding is that even if code bits would be referencing/relying on the old reader,
they could still use it as Javadoc says the old one should remain unclosed although the new
searches, etc. would carry on with the updated reader. Am I wrong?

> [PATCH] Allow setting IndexReader to IndexSearcher
> --------------------------------------------------
>
>                 Key: LUCENE-1203
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1203
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.3.1
>         Environment: Linux/2.6
>            Reporter: Mindaugas Žakšauskas
>         Attachments: IndexReaderSetter4IndexSearcher.patch
>
>
> As I've received no counter-arguments for my Lucene Java-User mailing list (see http://mail-archives.apache.org/mod_mbox/lucene-java-user/200803.mbox/%3Ca4d7dcf50803050918h68defe83v66e657debb76d3f3@mail.gmail.com%3E),
I would like to propose adding a setter to set new instance of IndexReader to IndexSearcher.

> Why is this needed?
> The FAQ (http://wiki.apache.org/lucene-java/LuceneFAQ#head-48921635adf2c968f7936dc07d51dfb40d638b82)
says:
> bq. ??"Make sure you only open one IndexSearcher, and share it among all of the threads
that are doing searches -- this is safe, and it will minimize the number of files that are
open concurently."??
> So does the JavaDoc (http://lucene.apache.org/java/2_3_1/api/core/org/apache/lucene/search/IndexSearcher.html).
> In my application, I don't want to expose anything about IndexReader; all they need to
know is Searcher - see my post to the mailing list how would I do this. However, if the index
is updated, reopened reader cannot be set back to IndexSearcher, a new instance of IndexSearcher
needs to be created (*which contradicts FAQ and Javadoc*).
> At the moment, the only way to go around this is to create a surrogate subclass of IndexSearcher
and set new instance of IndexReader. A simple setter would just do the job.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message