Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 63165 invoked from network); 11 Jun 2008 05:39:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Jun 2008 05:39:39 -0000 Received: (qmail 41729 invoked by uid 500); 11 Jun 2008 05:39:40 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 41689 invoked by uid 500); 11 Jun 2008 05:39:40 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 41670 invoked by uid 99); 11 Jun 2008 05:39:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jun 2008 22:39:40 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jun 2008 05:38:59 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id F0A6D234C139 for ; Tue, 10 Jun 2008 22:38:46 -0700 (PDT) Message-ID: <1915748290.1213162726984.JavaMail.jira@brutus> Date: Tue, 10 Jun 2008 22:38:46 -0700 (PDT) From: "Otis Gospodnetic (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-1297) Allow other string distance measures in spellchecker In-Reply-To: <1147377758.1212173804959.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604121#action_12604121 ] Otis Gospodnetic commented on LUCENE-1297: ------------------------------------------ Tom, note the bit about naming patches and reusing patch names on the HowToContribute wiki page. I see JaroWinklerDistance.java doesn't have ASL on top. Oh, there is something funky about this patch. You created a new class (LevenshteinDistance), but your patch shows it as an edit of TRStringDistance. It should show it as a brand new file. Could you please provide a clean patch? This is why the patch fails to apply. Thanks. > Allow other string distance measures in spellchecker > ---------------------------------------------------- > > Key: LUCENE-1297 > URL: https://issues.apache.org/jira/browse/LUCENE-1297 > Project: Lucene - Java > Issue Type: New Feature > Components: contrib/spellchecker > Affects Versions: 2.4 > Environment: n/a > Reporter: Thomas Morton > Assignee: Otis Gospodnetic > Priority: Minor > Fix For: 2.4 > > Attachments: string_distance.patch2 > > > Updated spelling code to allow for other string distance measures to be used. > Created StringDistance interface. > Modified existing Levenshtein distance measure to implement interface (and renamed class). > Verified that change to Levenshtein distance didn't impact runtime performance. > Implemented Jaro/Winkler distance metric > Modified SpellChecker to take distacne measure as in constructor or in set method and to use interface when calling. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org