[ https://issues.apache.org/jira/browse/LUCENE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604515#action_12604515
]
Grant Ingersoll commented on LUCENE-1297:
-----------------------------------------
Patch applies cleanly and the tests pass.
Ideally, there would be standalone tests for each of the distance measures that test them
outside the context of spell checking.
I think the Jaro-Winkler threshold should be configurable via a setter/constructor. A getter
would make sense too, so that one can see what the threshold is.
Also, the TRStringDistance explicitly states that it is not thread safe. I believe it is
now being used in a non thread-safe manner. FWIW, I see no reason why it can't be made thread-safe.
All of those member variables are being allocated in the getDistance method, so no reason
not to just make them local variables, I think.
> Allow other string distance measures in spellchecker
> ----------------------------------------------------
>
> Key: LUCENE-1297
> URL: https://issues.apache.org/jira/browse/LUCENE-1297
> Project: Lucene - Java
> Issue Type: New Feature
> Components: contrib/spellchecker
> Affects Versions: 2.4
> Environment: n/a
> Reporter: Thomas Morton
> Assignee: Otis Gospodnetic
> Priority: Minor
> Fix For: 2.4
>
> Attachments: string_distance3.patch
>
>
> Updated spelling code to allow for other string distance measures to be used.
> Created StringDistance interface.
> Modified existing Levenshtein distance measure to implement interface (and renamed class).
> Verified that change to Levenshtein distance didn't impact runtime performance.
> Implemented Jaro/Winkler distance metric
> Modified SpellChecker to take distacne measure as in constructor or in set method and
to use interface when calling.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
|