Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
In-Reply-To: <429707.60407.qm@web50309.mail.re2.yahoo.com>
References: <429707.60407.qm@web50309.mail.re2.yahoo.com>
Mime-Version: 1.0 (Apple Message framework v753)
Content-Type: multipart/mixed; boundary=Apple-Mail-1-710980217
Message-Id: <FA570908-7D52-4D22-990F-01778F858733@mikemccandless.com>
Cc: Otis Gospodnetic <otis_gospodnetic@yahoo.com>
From: Michael McCandless <lucene@mikemccandless.com>
Subject: Re: TestPayloads FAILED?
Date: Fri, 16 May 2008 10:00:14 -0400
To: java-dev@lucene.apache.org

--Apple-Mail-1-710980217
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	format=flowed


Otis, could you try the attached patch?

I just changed the test to consistently correct invalid UTF16 sequences.

Mike


--Apple-Mail-1-710980217
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=UTF-8;
	delsp=yes;
	format=flowed


Otis Gospodnetic wrote:
> Mike, yeah, I just got the test to fail a few more times and then =20
> pass once.  I *think* the expected vs. was output was slightly =20
> different in different failed runs, so it might be that random bit =20
> that's the culprit
>
> java.nio.charset.Charset.defaultCharset().name() gives me "UTF-8" =20
> on my JVM:
> $ java -version
> java version "1.6.0_03"
> Java(TM) SE Runtime Environment (build 1.6.0_03-b05)
> Java HotSpot(TM) Client VM (build 1.6.0_03-b05, mixed mode, sharing)
>
> Otis
> --
> Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch
>
>
> ----- Original Message ----
>> From: Michael McCandless <lucene@mikemccandless.com>
>> To: java-dev@lucene.apache.org
>> Sent: Wednesday, May 14, 2008 3:59:01 AM
>> Subject: Re: TestPayloads FAILED?
>>
>>
>> I can't get this testcase to fail.
>>
>> I've got in running over and over on Win XP / JRE 1.4 and OS X / JRE
>> 1.5 and haven't seen a failure.
>>
>> Otis what are the specs of your laptop?
>>
>> Hmm, actually, looking at that test, it generates a random byte
>> sequence as the payload and then builds a String from that byte
>> sequence using the default charset.  This is actually risky because
>> it's entirely possible this would randomly generate an invalid UTF16
>> string, which could cause that exact failure.
>>
>> Otis what's the default charset for the JRE (OS) on your laptop?
>>
>> Mike
>>
>> Otis Gospodnetic wrote:
>>> Hi,
>>>
>>> Is this just me?  I have not run unit tests in a loooong time and
>>> when I tried tonight this failed twice in a row.  I don't recall
>>> any mentions of this on the ML, plus we are not getting nb failure
>>> emails... just me and my laptop?
>>>
>>>     [junit] Testcase: testThreadSafety
>>> (org.apache.lucene.index.TestPayloads):   FAILED
>>>     [junit] expected:<[?]=EF=BF=BD=EF=BF=BD> but was:<[=EF=BF=BD]=EF=BF=
=BD=EF=BF=BD>
>>>     [junit] junit.framework.ComparisonFailure: expected:<[?]=EF=BF=BD=EF=
=BF=BD>
>>> but was:<[=EF=BF=BD]=EF=BF=BD=EF=BF=BD>
>>>     [junit]     at
>>> org.apache.lucene.index.TestPayloads.testThreadSafety
>>> (TestPayloads.java:514)
>>>     [junit] Test org.apache.lucene.index.TestPayloads FAILED
>>>
>>> Thanks,
>>> Otis
>>> --
>>> Sematext -- http://sematext.com/ -- Lucene - Solr - Nutch
>>>
>>>
>>> --------------------------------------------------------------------=20=

>>> -
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>


--Apple-Mail-1-710980217
Content-Type: text/plain; charset=us-ascii

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
--Apple-Mail-1-710980217--