Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <1122384182.1212106065238.JavaMail.jira@brutus>
Date: Thu, 29 May 2008 17:07:45 -0700 (PDT)
From: "Mike Klaas (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-1293) Tweaks to PhraseQuery.explain()
In-Reply-To: <1617343890.1211480636212.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600973#action_12600973 ] 

Mike Klaas commented on LUCENE-1293:
------------------------------------

It is meant for debugging, though I have found it so painfully slow in the past that I have avoided it on occasion.

The main culprit is the looped next() call in PhraseScorer.explain().  Using skipTo() would be faster.

> Tweaks to PhraseQuery.explain()
> -------------------------------
>
>                 Key: LUCENE-1293
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1293
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 1.9, 2.0.0, 2.1, 2.2, 2.3, 2.3.1, 2.3.2, 2.4
>            Reporter: Itamar Syn-Hershko
>            Priority: Minor
>             Fix For: 2.4
>
>
> The explain() function in PhraseQuery.java is very clumzy and could use many optimizations. Perhaps it is only because it is intended to use while debugging?
> Here's an example:
> {noformat}
>       result.addDetail(fieldExpl);
>       // combine them
>       result.setValue(queryExpl.getValue() * fieldExpl.getValue());
>       if (queryExpl.getValue() == 1.0f)
>         return fieldExpl;
>       return result;
>    }
> {noformat}
> Can easily be tweaked and become:
> {noformat}
>       if (queryExpl.getValue() == 1.0f) {
>         return fieldExpl;
>       }
>       result.addDetail(fieldExpl);
>       // combine them
>       result.setValue(queryExpl.getValue() * fieldExpl.getValue());
>       return result;
>   }
> {noformat}
> And thats really just for a start...
> Itamar.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org