lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-1278) Add optional storing of document numbers in term dictionary
Date Mon, 05 May 2008 12:01:55 GMT


Michael McCandless commented on LUCENE-1278:

I had a look at today's patch, but I stopped at DocumentsWriter because it contains a lot
of layout changes, so it's hard to focus on the functional differences.

I also stopped at DocumentsWriter: it seems like nearly all the
changes are cosmetic.  SegmentTermEnum is also hard to read.

In general it's best to not make cosmetic changes (moving around
import lines, changing whitespace, re-justifying whole paragraphs in
javadocs, etc.) at the same time as a "real" change, when possible.  I
do admit there is a strong temptation ;)

Also, indentation should be two spaces, not tab.  A number of sources
were changed to tab in the patch.

> Add optional storing of document numbers in term dictionary
> -----------------------------------------------------------
>                 Key: LUCENE-1278
>                 URL:
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Index
>    Affects Versions: 2.3.1
>            Reporter: Jason Rutherglen
>            Priority: Minor
>         Attachments: lucene.1278.5.4.2008.patch, lucene.1278.5.5.2008.patch
> Add optional storing of document numbers in term dictionary.  String index field cache
and range filter creation will be faster.  
> Example read code:
> {noformat}
> TermEnum termEnum = indexReader.terms(TermEnum.LOAD_DOCS);
> do {
>   Term term = termEnum.term();
>   if (term == null || term.field() != field) break;
>   int[] docs =;
> } while (;
> {noformat}
> Example write code:
> {noformat}
> Document document = new Document();
> document.add(new Field("tag", "dog", Field.Store.YES, Field.Index.UN_TOKENIZED, Field.Term.STORE_DOCS));
> indexWriter.addDocument(document);
> {noformat}

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message