lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-1294) Jar manifest should not contain ${user.name} of the person building
Date Wed, 28 May 2008 17:47:45 GMT
Jar manifest should not contain ${user.name} of the person building
-------------------------------------------------------------------

                 Key: LUCENE-1294
                 URL: https://issues.apache.org/jira/browse/LUCENE-1294
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Grant Ingersoll
            Assignee: Grant Ingersoll
            Priority: Trivial


Not sure if it is a big deal, but I don't particularly like that my user id for my build machine
is in the manifest of the JAR that I constructed.  It's a stretch, security-wise, I know,
but I don't see how it serves any useful purpose.  We have signatures/logs/SVN tags so we
know who built the particular item w/o needing to know what their local user account name
is.

The fix is:

{code}
Index: common-build.xml
===================================================================
--- common-build.xml    (revision 661027)
+++ common-build.xml    (working copy)
@@ -281,7 +281,7 @@
                <attribute name="Implementation-Title" value="org.apache.lucene"/>
                <!-- impl version can be any string -->
                <attribute name="Implementation-Version"
-                          value="${version} ${svnversion} - ${user.name} - ${DSTAMP} ${TSTAMP}"/>
+                          value="${version} ${svnversion} - ${DSTAMP} ${TSTAMP}"/>
                <attribute name="Implementation-Vendor"
                           value="The Apache Software Foundation"/>
                <attribute name="X-Compile-Source-JDK" 
{code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message