lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Otis Gospodnetic (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1295) Make retrieveTerms(int docNum) public in MoreLikeThis
Date Sat, 31 May 2008 04:27:45 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601340#action_12601340
] 

Otis Gospodnetic commented on LUCENE-1295:
------------------------------------------

I think cosmetic changes are OK if:
* they are not mixed with functional changes
* there are no patches for the cleaned-up class(es) in JIRA

In this case I see only a couple of MLT issues, all of which look like we can take care of
them quickly, and then somebody can clean up a little if we feel like it.  Anyhow...


> Make retrieveTerms(int docNum) public in MoreLikeThis
> -----------------------------------------------------
>
>                 Key: LUCENE-1295
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1295
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Trivial
>         Attachments: LUCENE-1295.patch
>
>
> It would be useful if 
> {code}
> private PriorityQueue retrieveTerms(int docNum) throws IOException {
> {code}
> were public, since it is similar in use to 
> {code}
> public PriorityQueue retrieveTerms(Reader r) throws IOException {
> {code}
> It also seems useful to add 
> {code}
> public String [] retrieveInterestingTerms(int docNum) throws IOException{
> {code}
> to mirror the one that works on Reader.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message