Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 21871 invoked from network); 11 Mar 2008 21:36:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Mar 2008 21:36:58 -0000 Received: (qmail 98397 invoked by uid 500); 11 Mar 2008 21:36:53 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 98337 invoked by uid 500); 11 Mar 2008 21:36:53 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 98324 invoked by uid 99); 11 Mar 2008 21:36:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Mar 2008 14:36:53 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.69.42.181] (HELO radix.cryptio.net) (208.69.42.181) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Mar 2008 21:36:16 +0000 Received: by radix.cryptio.net (Postfix, from userid 1007) id C705D71C362; Tue, 11 Mar 2008 14:36:26 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by radix.cryptio.net (Postfix) with ESMTP id C224171C356 for ; Tue, 11 Mar 2008 14:36:26 -0700 (PDT) Date: Tue, 11 Mar 2008 14:36:26 -0700 (PDT) From: Chris Hostetter To: java-dev@lucene.apache.org Subject: Re: Ideas to refactor Filed In-Reply-To: <5CBD8681-CE59-4BA9-9804-14ACF4009AE0@apache.org> Message-ID: References: <219524.70843.qm@web23001.mail.ird.yahoo.com> <85C71C2B-6FAE-4E7C-91A6-12B923D67EE0@mikemccandless.com> <5CBD8681-CE59-4BA9-9804-14ACF4009AE0@apache.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Checked: Checked by ClamAV on apache.org : I think, if you give it the same name, it just grays out the old ones. See : https://issues.apache.org/jira/browse/LUCENE-550 for an example. : : Thus, I prefer #3, but am fine with #2 as well. #3 makes it easier, IMO, to : find the latest. use the same name if the patch serves the same purpose (in the majority of issues, there is a linear evolution of a single patch). when doing this Jira recognizes that the patches "superceed" eachother, and allways prsents the latest at the top of the list with the others greyed out. use differnet names for patches that serve differnet purposes (ie: one patch which may go through several iterations using one approach, someone may then post a differnet patch with a differnet name which attempts to solve the same problem with a completely differnet approach, someone else may then post a third patch with a third name which provides unit tests that work against both of the other patches ... at which point all three different" patches" may be updated many times as they evolve in attempting to find the best ultimate solution. if you use differnet names for differnet iterations of the same "logical patch" it's very not easy to see in jira which one is the "newest" because jira orders patches with differnet names lexigraphically. you have to go to the "Manage Attachemnts" screen or view the full history of the issue to get any sense of when each differently name patch was added. -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org