lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Dillard (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-1248) Unncessary creation of object in org.apache.lucene.analysis.WordlistLoader.getWordSet()
Date Thu, 27 Mar 2008 19:41:24 GMT
Unncessary creation of object in org.apache.lucene.analysis.WordlistLoader.getWordSet()
---------------------------------------------------------------------------------------

                 Key: LUCENE-1248
                 URL: https://issues.apache.org/jira/browse/LUCENE-1248
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Analysis
    Affects Versions: 2.3.1, 2.3.2
            Reporter: David Dillard
            Priority: Trivial


Here's the function:

  public static HashSet getWordSet(File wordfile) throws IOException {
    HashSet result = new HashSet();
    FileReader reader = null;
    try {
      reader = new FileReader(wordfile);
      result = getWordSet(reader);
    }
    finally {
      if (reader != null)
        reader.close();
    }
    return result;
  }

The creation of the new HashSet object in the declaration of "result" is unnecessary.  Either
"result" will be unconditionally set by the call to getWordSet() or an exception will occur.

This was detected by FindBugs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message