lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Elschot (JIRA)" <>
Subject [jira] Updated: (LUCENE-1187) Things to be done now that Filter is independent from BitSet
Date Wed, 26 Mar 2008 18:25:24 GMT


Paul Elschot updated LUCENE-1187:

    Attachment: Contrib20080326.patch

Contrib20080326.patch: supersedes the 20080325 version. Generally the same as yesterday, some
- fix a possible synchronisation issue by using a local int[1] array instead of an object
int attribute,
- return a SortedVIntList when it is definitely smaller than an OpenBitSet, the method doing
this is protected.
- all constructors in OpenBitSetDISI now also take a initial size argument
(still called maxSize, perhaps better renamed to initialSize).

Both ChainedFilter and BooleanFilter should work normally, except perhaps using less memory
because of the SortedVIntList.

ChainedFilter still has the 1.1 ASL, it's probably time to upgrade it, but I did not change
it in the patch.

> Things to be done now that Filter is independent from BitSet
> ------------------------------------------------------------
>                 Key: LUCENE-1187
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>            Priority: Minor
>         Attachments: BooleanFilter20080325.patch, ChainedFilterAndCachingFilterTest.patch,
Contrib20080325.patch, Contrib20080326.patch, javadocsZero2Match.patch, OpenBitSetDISI-20080322.patch
> (Aside: where is the documentation on how to mark up text in jira comments?)
> The following things are left over after LUCENE-584 :
> For Lucene 3.0  Filter.bits() will have to be removed.
> There is a CHECKME in IndexSearcher about using ConjunctionScorer to have the boolean
behaviour of a Filter.
> I have not looked into Filter caching yet, but I suppose there will be some room for
improvement there.
> Iirc the current core has moved to use OpenBitSetFilter and that is probably what is
being cached.
> In some cases it might be better to cache a SortedVIntList instead.
> Boolean logic on DocIdSetIterator is already available for Scorers (that inherit from
DocIdSetIterator) in the search package. This is currently implemented by ConjunctionScorer,
> ReqOptSumScorer and ReqExclScorer.
> Boolean logic on BitSets is available in contrib/misc and contrib/queries
> DisjunctionSumScorer calls score() on its subscorers before the score value actually
> This could be a reason to introduce a DisjunctionDocIdSetIterator, perhaps as a superclass
of DisjunctionSumScorer.
> To fully implement non scoring queries a TermDocIdSetIterator will be needed, perhaps
as a superclass of TermScorer.
> The javadocs in using matching vs non-zero score:
> I'll investigate this soon, and provide a patch when necessary.
> An early version of the patches of LUCENE-584 contained a class Matcher,
> that differs from the current DocIdSet in that Matcher has an explain() method.
> It remains to be seen whether such a Matcher could be useful between
> DocIdSet and Scorer.
> The semantics of scorer.skipTo(scorer.doc()) was discussed briefly.
> This was also discussed at another issue recently, so perhaps it is wortwhile to open
a separate issue for this.
> Skipping on a SortedVIntList is done using linear search, this could be improved by adding
multilevel skiplist info much like in the Lucene index for documents containing a term.
> One comment by me of 3 Dec 2008:
> A few complete (test) classes are deprecated, it might be good to add the target release
for removal there.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message