lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doron Cohen (JIRA)" <>
Subject [jira] Updated: (LUCENE-1232) Use segments generation instead of version
Date Fri, 14 Mar 2008 18:46:24 GMT


Doron Cohen updated LUCENE-1232:

    Attachment: LUCENE-1232.dc.patch

I otoh liked this side effect of this change, i.e. that index version values 
will no longer be very large numbers, millis, but rather very readable 
numbers starting from 1.  But I didn't think of the problem Hoss pointed.

Anyhow I think that SegmentsInfo can be made a bit simpler by getting rid
of more 'version' related code - attached LUCENE-1232.dc.patch does this.
To prevent backwards compatibility issues it still writes and reads 0 (zero) for that version.
All tests pass.

> Use segments generation instead of version
> ------------------------------------------
>                 Key: LUCENE-1232
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.1, 2.2, 2.3, 2.3.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4
>         Attachments: check.version.vs.gen.diff, LUCENE-1232.dc.patch, LUCENE-1232.patch
> Right now the segments file stores generation, a long starting with 0
> that increments by 1 with each commit, and version, a long starting
> with System.currentTimeMillis() that also increments by 1 with each
> commit.
> I think they are redundant so we can replace all methods/uses of
> version with generation instead.
> Spinoff from LUCENE-1228.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message