lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (LUCENE-1184) Allow SnapshotDeletionPolicy to be reused across writer close/open
Date Tue, 26 Feb 2008 14:24:56 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless resolved LUCENE-1184.
----------------------------------------

    Resolution: Fixed

I just committed this.  Thanks Tim!

> Allow SnapshotDeletionPolicy to be reused across writer close/open
> ------------------------------------------------------------------
>
>                 Key: LUCENE-1184
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1184
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.3
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: LUCENE-1184.patch
>
>
> If you re-use the same instance of SnapshotDeletionPolicy across a
> close/open of your writer, and you had a snapshot open, it can still
> be removed when the 2nd writer is opened.  This is because SDP is
> comparing IndexCommitPoint instances.
> The fix is to instead compare segments file names.
> I've also changed the inner class IndexFileDeleter.CommitPoint to be
> static so an instance of SnapshotDeletionPolicy does not hold
> references to IndexFileDeleter, DocumentsWriter, etc.
> Spinoff from here:
>   http://markmail.org/message/bojgqfgyxkkv4fyb

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message