lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1163) CharArraySet.contains(char[] text, int off, int len) does not work
Date Tue, 05 Feb 2008 13:44:08 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael McCandless updated LUCENE-1163:
---------------------------------------

    Attachment: LUCENE-1163.patch

Indeed it's really a bug -- thank you for finding this & reporting it Thomas!

We were ignoring the offset when computing the hash code internally.

Lucene always passes '0' for this offset (only used in StopFilter currently) so it wasn't
hitting any existing Lucene test cases.

I turned your example into a test case in the attached patch.  I will commit shortly.

> CharArraySet.contains(char[] text, int off, int len) does not work
> ------------------------------------------------------------------
>
>                 Key: LUCENE-1163
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1163
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.3
>            Reporter: Thomas Peuss
>            Assignee: Michael McCandless
>         Attachments: CharArraySetShowBug.java, LUCENE-1163.patch
>
>
> I try to use the CharArraySet for a filter I am writing. I heavily use char-arrays in
my code to speed up things. I stumbled upon a bug in CharArraySet while doing that.
> The method _public boolean contains(char[] text, int off, int len)_ seems not to work.
> When I do 
> {code}
> if (set.contains(buffer,offset,length) {
>   ...
> }
> {code}
> my code fails.
> But when I do
> {code}
> if (set.contains(new String(buffer,offset,length)) {
>    ...
> }
> {code}
> everything works as expected.
> Both variants should behave the same. I attach a small piece of code to show the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message