Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 84305 invoked from network); 19 Nov 2007 20:46:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Nov 2007 20:46:55 -0000 Received: (qmail 72608 invoked by uid 500); 19 Nov 2007 20:46:40 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 72573 invoked by uid 500); 19 Nov 2007 20:46:40 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 72562 invoked by uid 99); 19 Nov 2007 20:46:40 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Nov 2007 12:46:40 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of yseeley@gmail.com designates 64.233.162.232 as permitted sender) Received: from [64.233.162.232] (HELO nz-out-0506.google.com) (64.233.162.232) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Nov 2007 20:46:44 +0000 Received: by nz-out-0506.google.com with SMTP id i28so1374118nzi for ; Mon, 19 Nov 2007 12:46:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=BMs5a/321XmDpoE+x5/ewMO9S02RASdB1Qv7f6uKilg=; b=PPcr9y3rUp9mQVpcEQPoDAI8dwMmlZ1Amka+HZau9rPh4zRZILGO7aUzDnVJ7FCfyU2GVTgoEls57N+Swp2eVbhio8LNVflkSITx9hnsfEBAhitzPg1ykFedep81YkcoNNaR1ovPuGyZMPOsCLn0Z4Q14EWlF5R1NbJop9LyqA8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=DOsVWD2eIiuMNtLOkVf0CrvGQdKYSVj8Imbx/N85danXlGE7jU5iNdS8CZQUmpll2XqP2REUcq3Q+a5DPh3ekZLguOd1UpLixp41PnTYsiGl42gXD60rMyqTaSOKPOHNtZIAzl9NlWrTKXXfCIX/LGXdkO8frm72PP5Ro66svGI= Received: by 10.143.157.10 with SMTP id j10mr1339919wfo.1195505182925; Mon, 19 Nov 2007 12:46:22 -0800 (PST) Received: by 10.143.165.13 with HTTP; Mon, 19 Nov 2007 12:46:22 -0800 (PST) Message-ID: Date: Mon, 19 Nov 2007 15:46:22 -0500 From: "Yonik Seeley" Sender: yseeley@gmail.com To: java-dev@lucene.apache.org Subject: Re: Payload API In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1195490280.7408.1222149151@webmail.messagingengine.com> <4741D41E.50909@gmail.com> <4741E72E.7070309@gmail.com> <4741ECBE.4020009@gmail.com> X-Google-Sender-Auth: efb37ce10c26b647 X-Virus-Checked: Checked by ClamAV on apache.org On Nov 19, 2007 3:31 PM, Yonik Seeley wrote: > On Nov 19, 2007 3:13 PM, Yonik Seeley wrote: > > The filter that is setting payloads can't use the same byte[] with a > > different value each time... it must allocate a new byte[] so it > > doesn't change the old one, right? > > OK... I think Mike is right... everything should be OK as long as > next() makes a copy of the payload. I just checked in a test for this payload copying, and a fix (under LUCENE-1057 since it all has to do with token reuse). -Yonik --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org