Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of buschmic@gmail.com designates
 209.85.132.248 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding;
        b=oP7DTZksfvY5d+wIpabtZQxoanZ9FWpMvwXTAEQY8Lqm1EhclLnUq+AXdM5oMuFS9zNg1kqWdxX4/z3u5Ntxzc+oBlX9V9Pa+SzWBUnMdW7H1jpFnNyT9UwfXQhGGNZ9bMZFwlFn87Pqwzl8SiKLloMUXpuYAeVlojlhFHoNI4M=
Message-ID: <474F49F3.1060106@gmail.com>
Date: Thu, 29 Nov 2007 15:23:31 -0800
From: Michael Busch <buschmic@gmail.com>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: java-dev@lucene.apache.org
Subject: Re: Payload Loading and Reloading
References: <A800917B-57B1-4731-80EB-9624EB3CA229@apache.org>
 <474F3E80.3020905@gmail.com>
 <4F4F30AB-8093-4A80-B116-BFE74582817B@apache.org>
In-Reply-To: <4F4F30AB-8093-4A80-B116-BFE74582817B@apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Grant Ingersoll wrote:

> 
> As for the cost of the seeks, why can't we just document that this is
> what is going on and discourage people from doing it?  

I'm just trying to keep SegmentTermPositions#getPayload() as efficient
as possible because it's often used in the most inner loops of scorers.
Keeping track of the start position of the payload adds overhead to that
method. I didn't profile it, maybe the overhead is not significant, but
I still don't see any usecase in which caching the latest payload is not
possible/sufficient. But maybe I'm missing one?


> I think caching it in SegTermPos. is the simplest

I don't think we should do caching here. Again, SegmentTermPositions is
used in inner loops, and often caching the last payload is not needed,
e. g. in BoostingTermQuery.

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org