lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tzvika Barenholz" <tzvika.barenh...@gmail.com>
Subject Re: some minor fixes
Date Mon, 19 Nov 2007 14:57:58 GMT
Duly noted. I created https://issues.apache.org/jira/browse/LUCENE-1059

Tzvika

On 11/19/07, Grant Ingersoll <gsingers@apache.org> wrote:
>
> Sure it fixes an issue.  I think a JIRA issue is the best way to make
> sure this doesn't get lost.
>
> -Grant
>
> On Nov 19, 2007, at 2:23 AM, Tzvika Barenholz wrote:
>
> > Hi Michael!
> >
> > The patch is attached to my previous message (and this one too). It
> > doesn't actually fix an issue, so I don't see where to put it
> > otherwise. Please advise. *trying not to be difficult* :-)
> >
> > T
> >
> > On 11/18/07, Michael McCandless <lucene@mikemccandless.com> wrote:
> >
> > Thank you!  Yes please submit a patch and we can iterate from there.
> >
> > Mike
> >
> > "Tzvika Barenholz" <tzvika.barenholz@gmail.com> wrote:
> > > Hello good people of Lucene!
> > >
> > > I've been using Lucene for a long while, but have only recently
> > had occasion
> > > to checkout the source code from the trunk and build it myself.
> > When I did
> > > so, I was alerted by my IDE (IDEA) of a large number of
> > irregularities in
> > > the code, some of them serious, most not. I made a patch
> > containing some of
> > > the obvious fixes: StringBuffer.append in stead of concatenation,
> > Boolean
> > > static instances instead of construction, System.arraycopy () in
> > stead of
> > > loops to the same effect, and Integer.toString in stead of
> > unnecessary
> > > construction. Minor things, to be sure, but still I thought it
> > best to share
> > > the diff, if you guys should think it worth committing. I did
> > verify that
> > > the ant common.test target passes after the change, which,
> > unsurprisingly,
> > > it did.
> > >
> > > I should note that there were many many other thing that I did not
> > change,
> > > for the reason that they would have made an inconveniently large
> > patch.  For
> > > example: many methods in Lucense are redundantly declared as
> > "private
> > > final"; many fields can be converted into local variables with the
> > same
> > > functionality. In some  cases strings are compared with string
> > literals
> > > using ==. I can give a list if anyone thinks he or she will have
> > use for
> > > it.
> > >
> > > That's it. Good  night and keep up the good work!
> > > Tzvika
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: java-dev-help@lucene.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: java-dev-help@lucene.apache.org
>
> --------------------------
> Grant Ingersoll
> http://lucene.grantingersoll.com
>
> Lucene Helpful Hints:
> http://wiki.apache.org/lucene-java/BasicsOfPerformance
> http://wiki.apache.org/lucene-java/LuceneFAQ
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message