lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robert engels <reng...@ix.netcom.com>
Subject Re: [jira] Commented: (LUCENE-743) IndexReader.reopen()
Date Mon, 12 Nov 2007 21:43:33 GMT
Why doesn't reopen get the 'read' lock, since commit has the write  
lock, it should wait...

On Nov 12, 2007, at 3:35 PM, Michael McCandless (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/LUCENE-743? 
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment- 
> tabpanel#action_12541955 ]
>
> Michael McCandless commented on LUCENE-743:
> -------------------------------------------
>
> I think the cause of the intermittant failure in the test is a missing
> try/finally in doReopen to properly close/decRef everything on
> exception.
>
> Because of lockless commits, a commit could be in-process while you
> are re-opening, in which case you could hit an IOexception and you
> must therefore decRef those norms you had incRef'd (and, close eg the
> newly opened FieldsReader).
>
>> IndexReader.reopen()
>> --------------------
>>
>>                 Key: LUCENE-743
>>                 URL: https://issues.apache.org/jira/browse/LUCENE-743
>>             Project: Lucene - Java
>>          Issue Type: Improvement
>>          Components: Index
>>            Reporter: Otis Gospodnetic
>>            Assignee: Michael Busch
>>            Priority: Minor
>>             Fix For: 2.3
>>
>>         Attachments: IndexReaderUtils.java, lucene-743- 
>> take2.patch, lucene-743-take3.patch, lucene-743-take4.patch,  
>> lucene-743-take5.patch, lucene-743-take6.patch, lucene-743- 
>> take7.patch, lucene-743.patch, lucene-743.patch, lucene-743.patch,  
>> MyMultiReader.java, MySegmentReader.java, varient-no- 
>> isCloneSupported.BROKEN.patch
>>
>>
>> This is Robert Engels' implementation of IndexReader.reopen()  
>> functionality, as a set of 3 new classes (this was easier for him  
>> to implement, but should probably be folded into the core, if this  
>> looks good).
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message